-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spdlog: make sure libdirs is empty when header_only=True #19283
Conversation
I detected other pull requests that are modifying spdlog/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ✔️
All green in build 2 (
|
FYI @RubenRBS, thx! 🙏🏻 |
@prince-chrismc? Anybody? Thanks!! |
@gegles You need to be more patient :) This PR is already approved and you can see the bot has been very hard at work (running smoothly as melted butter) |
I made prince-chrismc/conan-center-index-pending-review#1 because the bot merge rules do not match GitHub's UI and you can check on the status of all the pull requests You can see you're in the "Ready to Merge" Section |
Ah, ah, patience is not my strong suite, but I'll try harder 😉. Thanks for the link and info... I was just making sure things were progressing forward and wasn't quite sure where in the process things were. Now I can, thanks! You guys are doing a phenomenal job! I am very impress by the rigor and quality of this whole process and the Conan community! Thanks for all your hard work! Cheers. G. |
This has been a challenge for a long time, I used to be a very active contributor myself so I know first hand. The team is putting a ton of effort to really reach new heights. It warms our hearts to hear that its recognized 🥲 I started a thread with the team to see if we can surface this information so it's easier for new contributors, the internals of c3i have this info so we'll see what they think :) |
Specify library name and version: spdlog/1.12.0
This PR removes the following warning (on macOS) when the library is used in
header_only=True
mode: